Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The API's NetworkPolicy allows ingress to the API port from any source, so any pod in the cluster can reach it. Callers still need valid credentials, but there's no way to narrow access only to the application that uses it, as the chart already does for every other component.
This adds an optional
networkPolicy.api.ingressFrom, following the existingmetrics.sandboxRunner.ingressFrom.If empty (the default) we preserve the current behaviour, allowing access from any source. When set, we add the entries to the
fromsection of the API's ingress rule, for example:One thing to watch out for when using this: the ingress controller (with ingress.enabled) and Prometheus (with metrics.enabled) will both need to be added to
ingressFromwhen they are enabled, because they reach the API on the same port.Testing
helm templatewithvalues-local.yamlrenders identically before and after this change.fromblock.